Add full stops in diagnostic messages#40165
Merged
sandersn merged 3 commits intomicrosoft:masterfrom Sep 8, 2020
cherryblossom000:typo
Merged
Add full stops in diagnostic messages#40165sandersn merged 3 commits intomicrosoft:masterfrom cherryblossom000:typo
sandersn merged 3 commits intomicrosoft:masterfrom
cherryblossom000:typo
Conversation
|
|
| !!! error TS17016: The 'jsxFragmentFactory' compiler option must be provided to use JSX fragments with the 'jsxFactory' compiler option. | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| !!! error TS17016: The 'jsxFragmentFactory' compiler option must be provided to use JSX fragments with the 'jsxFactory' compiler option. No newline at end of file | ||
| !!! error TS17016: The 'jsxFragmentFactory' compiler option must be provided to use JSX fragments with the 'jsxFactory' compiler option. |
Member
There was a problem hiding this comment.
Why is there a diff here?
Contributor
Author
There was a problem hiding this comment.
I think VSCode added a newline to the end of the file and trimmed the whitespace when I was resolving merge conflicts.
sandersn
approved these changes
Sep 8, 2020
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Whew, there are 14 of them! I was afraid we had forgotten the period on basically every message. =)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37753